----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/901/#review1634 -----------------------------------------------------------
Ship it! It would be nice if we could specialize the flags for SE and FS modes since the behavior and requirements are different, but that probably wouldn't be worth the effort right now. Looks good to me. - Gabe On 2011-11-03 13:29:05, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/901/ > ----------------------------------------------------------- > > (Updated 2011-11-03 13:29:05) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ARM: Add IsSerializeAfter and IsNonSpeculative flag to the syscall > instruction . > > Squashes the subsequent instructions in O3 pipe after the service call, so > that > they see the effect of the system call when re-executed. This isn't really an > issue > with FS mode, but can show up in SE mode. > > > Diffs > ----- > > src/arch/arm/isa/insts/misc.isa 5fb918115c07 > > Diff: http://reviews.m5sim.org/r/901/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
