> On 2011-11-06 01:12:07, Gabe Black wrote: > > configs/example/fs.py, line 75 > > <http://reviews.m5sim.org/r/903/diff/1/?file=15413#file15413line75> > > > > Won't this create an enormous number of images? It's not wrong to do > > that, but I wonder if this is a very practical thing to do in most > > circumstances.
~30 frames per simulated second, but since a second can take hours, not really a problem. > On 2011-11-06 01:12:07, Gabe Black wrote: > > src/base/vnc/vncserver.cc, line 737 > > <http://reviews.m5sim.org/r/903/diff/1/?file=15420#file15420line737> > > > > Isn't this the function that's commented out above? I'm sure I've seen > > this patch before, because I remember commenting that this comparing hashes > > thing seemed like overkill. We know *exactly* when the contents of the > > framebuffer are modified because we are the only ones that could have > > changed it. Why don't we just set a dirty flag when that happens? We do know when we're active and the device is told to read a frame from simulated memory, however we don't know if the os actually changed the underlying image. Either way 30fps means we do this once every few minutes of execution, so it's not a performance worry. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/903/#review1636 ----------------------------------------------------------- On 2011-11-03 13:30:11, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/903/ > ----------------------------------------------------------- > > (Updated 2011-11-03 13:30:11) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > VNC: Add support for capturing frame buffer to file each time it is changed. > > When a change in the frame buffer from the VNC server is detected, the new > frame is stored out to the m5out/frames_*/ directory. Specifiy the flag > "--frame-capture" when running configs/example/fs.py to enable this behavior. > > > Diffs > ----- > > configs/example/fs.py 5fb918115c07 > src/base/bitmap.hh 5fb918115c07 > src/base/bitmap.cc 5fb918115c07 > src/base/vnc/VncServer.py 5fb918115c07 > src/base/vnc/convert.hh 5fb918115c07 > src/base/vnc/convert.cc 5fb918115c07 > src/base/vnc/vncserver.hh 5fb918115c07 > src/base/vnc/vncserver.cc 5fb918115c07 > > Diff: http://reviews.m5sim.org/r/903/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
