----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/913/#review1679 -----------------------------------------------------------
Ship it! - Ali On 2011-11-27 02:19:23, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/913/ > ----------------------------------------------------------- > > (Updated 2011-11-27 02:19:23) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > SWIG/base: Ensure that ptrdiff_t is available for SWIG by including cstddef. > > SWIG happily uses ptrdiff_t without including the file that defines it > explicitly. Certain newer versions of gcc apparently changed how that file > would be included transitively, so SWIG generated files may fail to build with > those gccs. This problem was supposedly solved with SWIG 2.0.3, I think, but > it seems to still exist in other places. I'm fixing it now because it was > triggered by the new fault injection code which was added somewhat recently. > Rather than counting on SWIG to do the right thing, I'm including cstddef in > base/types.hh so that it's more likely to get picked up in the right places. > This fixes the immediate problem but isn't a foolproof solution. > > > Diffs > ----- > > src/base/types.hh c226cd1e5e5e > > Diff: http://reviews.m5sim.org/r/913/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
