----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/923/#review1721 -----------------------------------------------------------
Ship it! - Steve On 2011-12-01 00:34:01, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/923/ > ----------------------------------------------------------- > > (Updated 2011-12-01 00:34:01) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Base: Fixed shift amount in genrand() to work with large numbers > > The previous version didn't work correctly with max integer values (2^31-1 > for 32-bit, 2^63-1 for 64bit version), causing "shift" to become -1. > For smaller numbers, it wouldn't have caused functional errors, but would > have resulted in more than necessary loops in the while loop. > Special-cased cases when (max + 1 == 0) to prevent the ceilLog2 functions > from failing. > > > Diffs > ----- > > src/base/random.cc d4e08e83f4fa > > Diff: http://reviews.m5sim.org/r/923/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
