----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/915/#review1759 -----------------------------------------------------------
Ship it! Looks good to me, assuming it works. Thanks for making the separate class. - Steve On 2011-12-12 12:37:51, Geoffrey Blake wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/915/ > ----------------------------------------------------------- > > (Updated 2011-12-12 12:37:51) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Packet: Enable functional reads of partial data to packet class > > This patch fixes a long standing defficiency in the packet class where > it was unable to handle finding data that partially satisfied a request. > > This splits out changes made to the packet class in the checkercpu patch as > requested by Ali. > > > Diffs > ----- > > src/mem/SConscript c1ab57ea8805 > src/mem/functional_packet.hh PRE-CREATION > src/mem/functional_packet.cc PRE-CREATION > src/mem/packet.hh c1ab57ea8805 > src/mem/packet.cc c1ab57ea8805 > src/mem/port.hh c1ab57ea8805 > src/mem/port.cc c1ab57ea8805 > > Diff: http://reviews.m5sim.org/r/915/diff > > > Testing > ------- > > Compiles. No functional changes made from CheckerCPU patch to this patch for > packet class, and CheckerCPU fully exercised this code path during testing. > > > Thanks, > > Geoffrey > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
