> On 2011-12-19 10:54:41, Ali Saidi wrote: > > src/SConscript, line 855 > > <http://reviews.m5sim.org/r/941/diff/1/?file=16347#file16347line855> > > > > Both of these need to be protected bythis if. no-unused-label isn't an > > option in gcc 4.4 on earlier. > > > > Andreas Hansson wrote: > That is very odd. Using gcc 4.2.1 (stock XCode 4.2) I get a warning about > an unused "fail" label, and with this switch enabled, the warning is not > treated as an error and compilation succeeds. In other words, it most > definitely seems to be a recognised option by gcc 4.2.1 on Mac. > > Any ideas? > > Andreas Hansson wrote: > After some digging...it definitely exists on gcc 4.2.2 (and I also tried > gcc 4.1.2 and this also works) > > gcc -dumpversion > 4.2.2 > > gcc -Werror -Wall -c -o test.o test.cc > cc1plus: warnings being treated as errors > test.cc: In function 'int main(int, char**)': > test.cc:4: warning: label 'label' defined but not used > > gcc -Werror -Wall -Wno-unused-label -c -o test.o test.cc > > >
Actually, I seem to stand corrected, I could find it mentioned in gcc documentation back to 4.1 (at least the -Wunused-label variant. Ali - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/941/#review1763 ----------------------------------------------------------- On 2011-12-19 05:52:33, Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/941/ > ----------------------------------------------------------- > > (Updated 2011-12-19 05:52:33) > > > Review request for Default. > > > Summary > ------- > > SWIG: Make gem5 compile and link with swig 2.0.4 > > To make gem5 compile and run with swig 2.0.4 a few minor fixes are > necessary, the fail label issues by swig must not be treated as an > error by gcc (tested with gcc 4.2.1), and the vector wrappers must > have SWIGPY_SLICE_ARG defined which happens in pycontainer.swg, > included through std_container.i. By adding the aforementioned include > to the vector wrappers everything seems to work. > > > Diffs > ----- > > src/SConscript ca98021c3f96 > src/python/m5/params.py ca98021c3f96 > > Diff: http://reviews.m5sim.org/r/941/diff > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
