Hey folks. I've noticed that a bunch of the reviews I've looked at recently (from ARM, although they're the ones posting reviews) that the indentation has been off in a lot of places. There should be four spaces for an indent, not two or three. You should be able to set up your favorite editor to do that automatically.

Please make sure that that especially and other style problems are fixed before submitting reviews. It takes a lot of extra time to flag problems like that, and they should be easy to fix ahead of time. That would also saves an unnecessary round trip through the review process.

Gabe

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to