----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/967/#review1806 -----------------------------------------------------------
src/sim/eventq.hh <http://reviews.m5sim.org/r/967/#comment2335> I still think that this needs better explanation and a big "DANGER" in the comment itself. Explain that you're doing this specifically for cache warm up and you had better know what you're doing if you're going to use this interface. I also think that the definition for this function should go in the .cc file. To me, it's the type of thing that you definitely don't want inlined. - Nathan On 2012-01-03 16:05:16, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/967/ > ----------------------------------------------------------- > > (Updated 2012-01-03 16:05:16) > > > Review request for Default. > > > Summary > ------- > > eventq: add a function for replacing head of the queue > This patch adds a function for replacing the event at the head of the queue > with another event. This helps in running a different set of events. Events > already scheduled can processed by replacing the original head event back. > > > Diffs > ----- > > src/sim/eventq.hh 09b482ee9ae0 > > Diff: http://reviews.m5sim.org/r/967/diff > > > Testing > ------- > > > Thanks, > > Nilay > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
