----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/932/#review1822 -----------------------------------------------------------
Ship it! 1) Why not add harmonic mean while you're at it? 2) I'd rather see these sorts of stats changes separate, but I won't insist. 3) I have no idea how much these stats are used. Does adding a log() to every sample affect performance much? Is the log() necessary? These are floating point numbers, so can't you just multiply them out? I'm not sure how hard it would be to compare m5.prof of one moderately complex run (O3 + cache hierarchy + a SPEC benchmark), but if it's not too hard, it might be worth a check. (I'd certainly prefer to just have the code in there since it is useful.) Again, I won't insist. src/base/stats/text.cc <http://reviews.m5sim.org/r/932/#comment2342> how about just gmean. src/sim/system.hh <http://reviews.m5sim.org/r/932/#comment2343> inline keyword is unnecessary inside a class body. return value should be on its own line. below too. - Nathan On 2011-12-16 13:36:29, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/932/ > ----------------------------------------------------------- > > (Updated 2011-12-16 13:36:29) > > > Review request for Default. > > > Summary > ------- > > WorkItems: Enables run time sampling for code marked using pseudo insts. > > Enhances histogram stat to report geometric mean. > Adds mechanism to collect run time samples for specific portions of a > benchmark, > using work_begin and work_end pseudo instructions. > > > Diffs > ----- > > src/base/statistics.hh ca98021c3f96 > src/base/stats/info.hh ca98021c3f96 > src/base/stats/text.cc ca98021c3f96 > src/python/m5/main.py ca98021c3f96 > src/sim/System.py ca98021c3f96 > src/sim/pseudo_inst.cc ca98021c3f96 > src/sim/system.hh ca98021c3f96 > src/sim/system.cc ca98021c3f96 > > Diff: http://reviews.m5sim.org/r/932/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
