----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/930/#review1823 -----------------------------------------------------------
Ship it! Sorry to be pedantic. I just hate duplicated code. :) It's not so bad that I require the change and I don't need to review it again if you choose to make the changes I suggest. Finally, why do you want the pickle format? I ask because json might be more generally useful. basically replace pickle.dump with json.dump and then a lot more stuff could suck in the json. (Someone could build a pretty javascript thing with canvas for displaying the configuration :) src/python/m5/SimObject.py <http://reviews.m5sim.org/r/930/#comment2344> This seems to be a massive repeat of the print_ini code. Could you build the ini_file code on top of this code? Also, the name ini_str is pretty outdated, is it still necessary? does str() work? We could also separate __str__ and __repr__ (though that could certainly be a separate change. src/python/m5/SimObject.py <http://reviews.m5sim.org/r/930/#comment2345> remove newline :P src/python/m5/main.py <http://reviews.m5sim.org/r/930/#comment2346> how about --pickle-config or --pickle-conf. Not sure if people know what pkl would mean src/python/m5/simulate.py <http://reviews.m5sim.org/r/930/#comment2347> Seems that you could use the get_dict() class here and keep the ini specific code all right here. - Nathan On 2011-12-16 13:35:00, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/930/ > ----------------------------------------------------------- > > (Updated 2011-12-16 13:35:00) > > > Review request for Default. > > > Summary > ------- > > config: support outputing a pickle of the configuration tree > > This is useful as an input potential input to power models and visualization > tools. > > > Diffs > ----- > > src/python/m5/SimObject.py ca98021c3f96 > src/python/m5/main.py ca98021c3f96 > src/python/m5/params.py ca98021c3f96 > src/python/m5/simulate.py ca98021c3f96 > > Diff: http://reviews.m5sim.org/r/930/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
