----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/929/#review1837 -----------------------------------------------------------
Don't see any obvious problems (i.e., it's not obvious there are no problems...) other than the style nits. Need to go through and make sure there's a space after commas in arg lists, particularly after the first arg of DPRINTF. src/cpu/o3/bpred_unit_impl.hh <http://reviews.m5sim.org/r/929/#comment2364> Is there an extra blank line here? - Steve On 2011-12-13 10:02:20, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/929/ > ----------------------------------------------------------- > > (Updated 2011-12-13 10:02:20) > > > Review request for Default. > > > Summary > ------- > > BPred: Fix RAS to handle predicated call/return instructions. > > Change RAS to fix issues with predicated call/return instructions. > Handled all cases in the life of a predicated call and return instruction. > > > Diffs > ----- > > src/cpu/o3/bpred_unit.hh c1ab57ea8805 > src/cpu/o3/bpred_unit_impl.hh c1ab57ea8805 > src/cpu/o3/commit_impl.hh c1ab57ea8805 > src/cpu/pred/tournament.cc c1ab57ea8805 > > Diff: http://reviews.m5sim.org/r/929/diff > > > Testing > ------- > > Works for all regressions tests, however dependent branch predictor patch > exposes x86 issues > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
