-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/937/#review1841
-----------------------------------------------------------

Ship it!


Looks reasonable, assuming Andreas's recent cleanup of this code doesn't make 
this obsolete.

- Steve


On 2011-12-16 13:38:19, Ali Saidi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/937/
> -----------------------------------------------------------
> 
> (Updated 2011-12-16 13:38:19)
> 
> 
> Review request for Default.
> 
> 
> Summary
> -------
> 
> Bus: Simulation fatals instead of segfault when the destination port is NULL.
> This occurs when the bus gets an access to address for which doesn't have port
> for. Happens when the addrange or devices are not set up properly.
> 
> 
> Diffs
> -----
> 
>   src/mem/bus.cc ca98021c3f96 
> 
> Diff: http://reviews.m5sim.org/r/937/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ali
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to