> On 2012-01-04 20:05:39, Steve Reinhardt wrote: > > src/cpu/o3/cpu.hh, line 383 > > <http://reviews.m5sim.org/r/935/diff/1/?file=16324#file16324line383> > > > > Is this just to get around the fact that traceFunctions() is protected > > and thus can't be called directly from the Commit object? If so, I'd > > prefer to just make traceFunctions() public than to add this.
Yes. Ok. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/935/#review1836 ----------------------------------------------------------- On 2011-12-16 13:37:30, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/935/ > ----------------------------------------------------------- > > (Updated 2011-12-16 13:37:30) > > > Review request for Default. > > > Summary > ------- > > O3: Add support of function tracing with O3 CPU. > > > Diffs > ----- > > src/cpu/o3/commit_impl.hh ca98021c3f96 > src/cpu/o3/cpu.hh ca98021c3f96 > > Diff: http://reviews.m5sim.org/r/935/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
