> On 2012-01-04 20:01:48, Steve Reinhardt wrote: > > I'm confused. Do they assert when they're enabled? > > Ali Saidi wrote: > Yes. These things have been in there forever and I think I'm the third > person to say that the assert must be wrong because we constantly run with > opt/fast with these asserts removed without issue.
Makes sense now. Looks good to me. I'd click "ship it" if you could do that inside a nested comment. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/931/#review1835 ----------------------------------------------------------- On 2011-12-16 13:35:44, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/931/ > ----------------------------------------------------------- > > (Updated 2011-12-16 13:35:44) > > > Review request for Default. > > > Summary > ------- > > O3: Remove some asserts that no longer seem to be valid. > > We've been running with these removed for (and they're not actually present > in opt/fast) for months now. I'm convinced this assert is no longer valid. > > > Diffs > ----- > > src/cpu/o3/decode_impl.hh ca98021c3f96 > src/cpu/o3/rename_impl.hh ca98021c3f96 > > Diff: http://reviews.m5sim.org/r/931/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
