On 01/10/12 22:28, Steve Reinhardt wrote: > How much do people care about consistency between: > > Port *p; > > vs. > > Port* p; > > ? > > The style guide is silent on the matter, but we have traditionally done the > former. I see Andreas tends to do the latter in his patches. I expect > there are other places where this modern style has slipped in already (kids > these days!). Should we encode the former as official style and make > Andreas change, or be flexible and let it go? > > Steve > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev
I'm used to the first style so it's my preference, and when declaring multiple pointers it weakly prevents declaring one pointer followed by several non-pointers, a la: Port *p, *q; vs. Port* p, q; If we pick anything I think we should pick the first one, and perhaps because of that bias I don't think it would be unreasonable to make that official. I'd generally like to avoid making the style rules too extensive and cumbersome, though, so I don't want to push for that too much either. Gabe _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
