----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/995/#review1950 -----------------------------------------------------------
Ship it! Given that this looks identical to the ARM version except for the names of a couple of utility functions it calls, I wonder why we don't have a default version defined on BaseRemoteGDB that they can both inherit. That's future work though. This patch is fine as it is. - Steve On 2012-01-16 07:49:09, Deyuan Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/995/ > ----------------------------------------------------------- > > (Updated 2012-01-16 07:49:09) > > > Review request for Default. > > > Summary > ------- > > [--splitting the mips-fs patch--] > Implement the RemoteGDB::acc function for full system mode debugging. > > > Diffs > ----- > > src/arch/mips/remote_gdb.cc f348cf78072c > > Diff: http://reviews.m5sim.org/r/995/diff > > > Testing > ------- > > > Thanks, > > Deyuan > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
