-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/996/#review1951
-----------------------------------------------------------


We keep #include statements sorted alphabetically, so this needs to move up a 
couple of lines.
http://gem5.org/Coding_Style#.23includes

Sorry for the nitpicking... thanks for submitting this.

Perhaps we should start compiling MIPS_FS in our regressions.

- Steve


On 2012-01-16 07:57:28, Deyuan Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/996/
> -----------------------------------------------------------
> 
> (Updated 2012-01-16 07:57:28)
> 
> 
> Review request for Default.
> 
> 
> Summary
> -------
> 
> [--splitting the mips-fs patch--]
> We need to add VtoPhys debugging flag head file, because the flag is used in 
> vtophys.cc.
> 
> 
> Diffs
> -----
> 
>   src/arch/mips/vtophys.cc f348cf78072c 
> 
> Diff: http://reviews.m5sim.org/r/996/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Deyuan
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to