----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/994/#review1962 -----------------------------------------------------------
configs/example/fs.py <http://reviews.m5sim.org/r/994/#comment2467> Is it possible to move this code into makeLinuxMipsSystem instead of into isa.cc? Maybe even move the line setMipsOptions right under that function call. If the code is copied into isa.cc, then those values should really be hardcoded into the registers (since there isn't any configuration to be done here.) src/arch/mips/isa.cc <http://reviews.m5sim.org/r/994/#comment2466> Let's move configCP() to the constructor behind the clear() line (instead of in the clear() function). This way, the clear() function doesn't have two tasks: clear state and reset state. - Korey On 2012-01-16 08:45:46, Deyuan Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/994/ > ----------------------------------------------------------- > > (Updated 2012-01-16 08:45:46) > > > Review request for Default. > > > Summary > ------- > > [--splitting the mips-fs patch--] > We can do the CP0 initialization in configCP(), then make ISA::clear() > function call the configCP() in isa.cc. > After that, the setMipsOptions() function in fs.py will be no longer needed. > > > Diffs > ----- > > configs/example/fs.py f348cf78072c > src/arch/mips/isa.cc f348cf78072c > > Diff: http://reviews.m5sim.org/r/994/diff > > > Testing > ------- > > > Thanks, > > Deyuan > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
