----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1013/#review1998 -----------------------------------------------------------
src/arch/arm/isa.hh <http://reviews.gem5.org/r/1013/#comment2505> Since you're saying which particular mode, you probably should drop the "an". src/arch/arm/mt.hh <http://reviews.gem5.org/r/1013/#comment2503> A lot of these headers aren't needed. using namespace std; isn't needed either. src/arch/arm/mt.hh <http://reviews.gem5.org/r/1013/#comment2504> It's outside the scope of this change, but these functions are only ever going to do something on MIPS, and if they're ever called anywhere else the simulation will die. I'd really love to see them go away at some point. It's like how Henry Ford said you could get your car in any color, as long as it's black. You can call these functions in any ISA, as long as its MIPS. - Gabe Black On Jan. 27, 2012, 1:20 a.m., Korey Sewell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1013/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2012, 1:20 a.m.) > > > Review request for Default. > > > Description > ------- > > inorder-arm: make arm InOrderCPU compilable > > > Diffs > ----- > > src/arch/arm/isa.hh 73116cbeacba > src/arch/arm/mt.hh PRE-CREATION > src/cpu/inorder/inorder_dyn_inst.hh 73116cbeacba > > Diff: http://reviews.gem5.org/r/1013/diff/diff > > > Testing > ------- > > > Thanks, > > Korey Sewell > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
