----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1016/#review2002 -----------------------------------------------------------
Ship it! Looks good to me. - Nilay Vaish On Jan. 27, 2012, 5:03 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1016/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2012, 5:03 a.m.) > > > Review request for Default. > > > Description > ------- > > Thread: Use inherited baseCpu rather than cpu in SimpleThread > > This patch is a trivial simplification, removing the cpu pointer from > SimpleThread and relying on the baseCpu pointer in ThreadState. The > patch does not add or change any functionality, it merely cleans up > the code. > > > Diffs > ----- > > src/cpu/simple_thread.hh 73116cbeacba > src/cpu/simple_thread.cc 73116cbeacba > src/cpu/thread_state.hh 73116cbeacba > > Diff: http://reviews.gem5.org/r/1016/diff/diff > > > Testing > ------- > > util/regress passes for all (excluding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
