> On Jan. 27, 2012, 11:16 a.m., Nilay Vaish wrote: > > Andreas, can include this line in the function create_system() > > in Ruby.py in configs/ruby? I think that will cover all the > > Ruby related scripts, though I am not aware of the order in > > which things should happen. > > Andreas Hansson wrote: > I've followed your suggestion and it will be part of tonight's > regression. One thing that struck me is that some script, e.g. o3-timing-ruby > and simple-atomic-ruby do not use create_system but rather Ruby.generate. > There do not seem to be any tests running these scripts though. > > I'll post an update once the regressions pass. > > Andreas Hansson wrote: > util/regress passes for all (excluding t1000 and eio)
Commit it! - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1015/#review2003 ----------------------------------------------------------- On Jan. 27, 2012, 9:49 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1015/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2012, 9:49 a.m.) > > > Review request for Default. > > > Description > ------- > > Ruby: Connect system port in Ruby network test > > This patch connects the system port and thereby allows the failing > Ruby test (and other Ruby systems) to run again. > > > Diffs > ----- > > configs/example/ruby_direct_test.py 73116cbeacba > configs/example/ruby_mem_test.py 73116cbeacba > configs/example/ruby_network_test.py 73116cbeacba > configs/example/ruby_random_test.py 73116cbeacba > tests/configs/o3-timing-mp-ruby.py 73116cbeacba > tests/configs/o3-timing-ruby.py 73116cbeacba > tests/configs/simple-atomic-mp-ruby.py 73116cbeacba > > Diff: http://reviews.gem5.org/r/1015/diff/diff > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
