----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/988/#review2054 -----------------------------------------------------------
Thanks for submitting this. Sorry for the slow response. If you'd like I can delete the comment mentioned below and commit this in your name. src/cpu/o3/dyn_inst.hh <http://reviews.gem5.org/r/988/#comment2543> It's not clear to me what the Impl stuff is really used for anymore, particularly with respect to this BaseDynInst class. I think we're better off just getting rid of the whole comment since none of it seems obviously helpful. - Steve Reinhardt On Jan. 11, 2012, 10:44 a.m., Paul Rosenfeld wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/988/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2012, 10:44 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8681:13f5134a2a87 > --------------------------- > imported patch alpha_comments.patch > > These are mostly removing dead comments. > > > Diffs > ----- > > src/arch/alpha/isa/mem.isa 508bbec99e58 > src/cpu/o3/dyn_inst.hh 508bbec99e58 > > Diff: http://reviews.gem5.org/r/988/diff/diff > > > Testing > ------- > > Ran ALPHA_SE tests and eio failed, but all others passed. > > > Thanks, > > Paul Rosenfeld > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
