> On Feb. 2, 2012, 10:21 a.m., Steve Reinhardt wrote: > > src/dev/CopyEngine.py, line 36 > > <http://reviews.gem5.org/r/1004/diff/1/?file=21246#file21246line36> > > > > Is there only one port? If so, why not just call it "dma"? That seems > > more in line with our standard practice. > > Ali Saidi wrote: > there are N ports depending on how the dma engine is configured > > > Steve Reinhardt wrote: > Are there N ports with different names, or are you just referring to the > fact that it's a VectorPort?
One vertor port called ce_dma or dma, with N elements. I'm happy to change the name, although currently all ports called dma are single element ports. Thoughts? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1004/#review2060 ----------------------------------------------------------- On Jan. 18, 2012, 2:34 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1004/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2012, 2:34 a.m.) > > > Review request for Default. > > > Description > ------- > > MEM: Explicit ports and Python binding on CopyEngine > > The copy-engine ports were previously created implicitly and bound > based on the dma port peer rather than relying on the normal Python > binding (connectPorts) being called explicitly. This patch makes the > copy engine port similar to all other ports in that they are visibly > in the Python class and bound using the normal explicit calls through > Python. > > > Diffs > ----- > > src/dev/CopyEngine.py 03e09db82c80 > src/dev/copy_engine.hh 03e09db82c80 > src/dev/copy_engine.cc 03e09db82c80 > > Diff: http://reviews.gem5.org/r/1004/diff/diff > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
