-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1002/#review2109
-----------------------------------------------------------
Ship it!
Looks fine to me with or without the port_ prefix. The name I gave was just a
suggestion. Part of the reasoning was that this would be easy to expand into a
struct later, e.g., port_${name}.connection_count. If it's simply length
that's bugging you, you could also abbreviate "connection" as "conn".
Any of these options are fine, and if it turns out to be confusing we can
always rename it later. Just pick one and commit it; no need to repost a diff
on my account.
- Steve Reinhardt
On Feb. 9, 2012, 11:46 a.m., Andreas Hansson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1002/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2012, 11:46 a.m.)
>
>
> Review request for Default.
>
>
> Description
> -------
>
> MEM: Pass the ports from Python to C++ using the Swig params
>
> This patch adds basic information about the ports in the parameter
> classes to be passed from the Python world to the corresponding C++
> object. Currently, the only information passed is the number of
> connected peers, which for a Port is either 0 or 1, and for a
> VectorPort reflects the size of the VectorPort. The default port of
> the bus had to be renamed to avoid using the name "default" as a field
> in the parameter class. It is possible to extend the Swig'ed
> information further and add e.g. a pair with a description and size.
>
>
> Diffs
> -----
>
> src/python/m5/SimObject.py 4f2ad221ae32
> src/python/m5/params.py 4f2ad221ae32
>
> Diff: http://reviews.gem5.org/r/1002/diff/diff
>
>
> Testing
> -------
>
> util/regress all passing (disregarding t1000 and eio)
>
>
> Thanks,
>
> Andreas Hansson
>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
