----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1033/#review2124 -----------------------------------------------------------
Without picking through it all in too much detail it looks ok to me. You should feel free to add all the reference files. The regressions aren't just diffed, generally they'll only fail if the stats change. Even then, ones that reflect host performance (number of host seconds, host instruction rate, amount of host memory consumed) are ignored. - Gabe Black On Feb. 10, 2012, 3:26 p.m., Geoffrey Blake wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1033/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2012, 3:26 p.m.) > > > Review request for Default. > > > Description > ------- > > CheckerCPU: Make some basic regression tests for CheckerCPU > > Dual purposes the se/00.hello and fs/10.linux-boot regression tests as > tests for the CheckerCPU for the ARM ISA only. > > > Diffs > ----- > > tests/configs/o3-timing-checker.py PRE-CREATION > tests/configs/realview-o3-checker.py PRE-CREATION > tests/configs/simple-atomic-dummychecker.py PRE-CREATION > tests/long/fs/10.linux-boot/ref/arm/linux/realview-o3-checker/config.ini > PRE-CREATION > tests/long/fs/10.linux-boot/ref/arm/linux/realview-o3-checker/stats.txt > PRE-CREATION > tests/quick/se/00.hello/ref/arm/linux/o3-timing-checker/config.ini > PRE-CREATION > tests/quick/se/00.hello/ref/arm/linux/o3-timing-checker/stats.txt > PRE-CREATION > tests/quick/se/00.hello/ref/arm/linux/simple-atomic-dummychecker/config.ini > PRE-CREATION > tests/quick/se/00.hello/ref/arm/linux/simple-atomic-dummychecker/stats.txt > PRE-CREATION > tests/quick/se/00.hello/test.py 8f354c5a1634 > > Diff: http://reviews.gem5.org/r/1033/diff/diff > > > Testing > ------- > > Compiles. > The se/00.hello an fs/10.linux-boot tests run to completion sucessfully. > > > Thanks, > > Geoffrey Blake > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
