-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1043/#review2148
-----------------------------------------------------------
I'm OK with this diff, but I feel like you're going to probably need a prepare
callback as well. If that's the case, I wonder if we should just have a single
object that looks like this:
class StatsCallback {
virtual void reset() {}
virtual void prepare() {}
virtual void dump() {}
};
then register just one callback and override whatever you need for a particular
case.
- Nathan Binkert
On Feb. 13, 2012, 3:47 p.m., Ali Saidi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1043/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2012, 3:47 p.m.)
>
>
> Review request for Default.
>
>
> Description
> -------
>
> stats: Provide a mechanism to get a callback when stats are dumped.
>
> This mechanism is useful for dumping output that is correlated with stats
> dumping, but isn't tracked by the gem5 statistics.
>
>
> Diffs
> -----
>
> src/base/statistics.hh a451e4eda591
> src/base/statistics.cc a451e4eda591
> src/python/m5/stats/__init__.py a451e4eda591
> src/python/swig/stats.i a451e4eda591
>
> Diff: http://reviews.gem5.org/r/1043/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ali Saidi
>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
