----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1051/#review2196 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On Feb. 16, 2012, 10:46 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1051/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2012, 10:46 a.m.) > > > Review request for Default. > > > Description > ------- > > Ruby: Simplify tester ports by not using SimpleTimingPort > > This patch simplfies the master ports used by RubyDirectedTester and > RubyTester by avoiding the use of SimpleTimingPort. Neither tester > made any use of the functionality offered by SimpleTimingPort besides > a trivial implementation of recvFunctional (only snoops) and > recvRangeChange (not relevant since there is only one master). > > The patch does not change or add any functionality, it merely makes > the introduction of a master/slave port easier (in a future patch). > > > Diffs > ----- > > src/cpu/testers/directedtest/RubyDirectedTester.hh ef8630054b5e > src/cpu/testers/rubytest/RubyTester.hh ef8630054b5e > > Diff: http://reviews.gem5.org/r/1051/diff/diff > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
