----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1059/#review2230 -----------------------------------------------------------
src/dev/arm/RealView.py <http://reviews.gem5.org/r/1059/#comment2686> Either size = pio_size or pio_size - 1 as the second argument. src/dev/arm/RealView.py <http://reviews.gem5.org/r/1059/#comment2687> Maybe a bit more detail for what these regions correspond to. system/arm/simple_bootloader/Makefile <http://reviews.gem5.org/r/1059/#comment2688> Why not use: $(LD) -o $@ -N -Ttext 0x00000010 $< -non_shared -static? The same applies to the other rules. system/arm/simple_bootloader/Makefile <http://reviews.gem5.org/r/1059/#comment2690> For clean I would suggest "$(RM) -f" as it will not object if the files do not exist. boot_emm.arm should probably be added as well. system/arm/simple_bootloader/Makefile <http://reviews.gem5.org/r/1059/#comment2689> Technically there should also be a line: .PHONY: all clean - Andreas Hansson On Feb. 22, 2012, 12:15 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1059/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2012, 12:15 p.m.) > > > Review request for Default. > > > Description > ------- > > > ARM: Add support for Versatile Express extended memory map > > Also clean up how we create boot loader memory a bit. > > > Diffs > ----- > > configs/common/FSConfig.py 2629f0b99e8d > configs/example/fs.py 2629f0b99e8d > src/arch/arm/ArmSystem.py 2629f0b99e8d > src/arch/arm/isa.cc 2629f0b99e8d > src/arch/arm/linux/system.hh 2629f0b99e8d > src/arch/arm/linux/system.cc 2629f0b99e8d > src/dev/arm/RealView.py 2629f0b99e8d > src/dev/arm/rv_ctrl.cc 2629f0b99e8d > system/arm/simple_bootloader/Makefile 2629f0b99e8d > > Diff: http://reviews.gem5.org/r/1059/diff/ > > > Testing > ------- > > boots a 3.2 kernel with the extended memory map & 2GB of DRAM > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
