----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1065/#review2234 -----------------------------------------------------------
Ship it! Assuming no backward compatibility problems for older gcc or swig versions... I can't see why there would be. - Steve Reinhardt On Feb. 28, 2012, 4:53 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1065/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2012, 4:53 a.m.) > > > Review request for Default. > > > Description > ------- > > SWIG: Ensure ptrdiff_t is a known type in gcc >= 4.6.1 > > This patch fixes a compilation error that occurs with gcc >= 4.6.1, > caused by swig not including cstddef and not using the std:: namespace > prefix for ptrdiff_t. There is an old patch, > http://reviews.m5sim.org/r/913/ that no longer applies cleanly and > this might be re-iterating the same issue. > > We work around the problem by always enforcing the inclusion of > cstddef in all swig interface declarations, and also by explicitly > using std::ptrdiff_t. > > > Diffs > ----- > > src/python/m5/SimObject.py c68ae0f78d8e > > Diff: http://reviews.gem5.org/r/1065/diff/ > > > Testing > ------- > > compiled for all ISAs using gcc 4.6.2 and swig 2.0.4 > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
