----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1075/#review2268 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On March 2, 2012, 5:57 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1075/ > ----------------------------------------------------------- > > (Updated March 2, 2012, 5:57 a.m.) > > > Review request for Default. > > > Description > ------- > > Ruby: Rename RubyPort::sendTiming to avoid overriding base class > > This patch renames the sendTiming member function in the RubyPort to > avoid inadvertently hiding Port::sendTiming (discovered through some > rather painful debugging). The RubyPort does, in fact, rely on the > functionality of the queued port and the implementation merely > schedules a send the next cycle. The new name for the member function > is sendNextCycle to better reflect this behaviour. > > In the unlikely event that we ever shift to using C++11 the member > functions in Port should have a "final" identifier to prevent any > overriding in derived classes. > > > Diffs > ----- > > src/mem/ruby/system/RubyPort.hh 9f1c4729d89d > src/mem/ruby/system/RubyPort.cc 9f1c4729d89d > > Diff: http://reviews.gem5.org/r/1075/diff/ > > > Testing > ------- > > util/regress quick passing for all ALPHA_* > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
