> On March 9, 2012, 11:36 a.m., Steve Reinhardt wrote: > > So did these files get changed to remove the warning? Or are there > > warnings with other versions of gcc? I'm curious about the history here... > > it seems a little dangerous to take these off unless we know that the > > reasons for having them there have been addresses.
There are no warnings with any version of gcc >= 4.2 at least. That's all I've been able to test. Was a -Wno-<insert warning here> flag added at some point perhaps? I cannot imagine that any older version of gcc would have problems when the more recent ones don't. Plus, if they do, then let's fix the code rather than disable -Werror. Agreed? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1082/#review2293 ----------------------------------------------------------- On March 6, 2012, 9:18 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1082/ > ----------------------------------------------------------- > > (Updated March 6, 2012, 9:18 a.m.) > > > Review request for Default. > > > Description > ------- > > Scons: Remove Werror=False in SConscript files > > This patch removes the overriding of "-Werror" in a handful of > cases. The code compiles with gcc 4.6.3 and clang 3.0 without any > warnings, and thus without any errors. There are no functional changes > introduced by this patch. In the future, rather than ypassing > "-Werror", address the warnings. > > > Diffs > ----- > > src/cpu/testers/networktest/SConscript b5d80698c948 > src/mem/ruby/common/SConscript b5d80698c948 > src/mem/ruby/network/garnet/fixed-pipeline/SConscript b5d80698c948 > > Diff: http://reviews.gem5.org/r/1082/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
