On Mar 10, 2012, at 12:10 PM, Nilay Vaish wrote: > On Fri, 9 Mar 2012, Brian Grayson wrote: > >> I was trying to do some bounds benchmarking to debug a bug (more about that >> later), and set the fetchWidth to 12, and all sorts of badness and memory >> corruption ensued, leading to a segfault. The following patch adds a check >> that the fetchWidth is set below Impl::MaxWidth, and notifies the user how >> to adjust the hard-coded constant if desired, following the lead of >> MaxThreads. >> > > It seems to me that there should be no limit on what the width can be set > to. Is there any reason why Impl::MaxWidth is required? It's required to appropriately size the structures that pass instructions between stages. It could be done dynamically, but i imagine that would create a rather large performance penalty since data that has lots of spacial locality no longer would. I think the change is good and will commit it.
FYI, we have a review board (reviews.gem5.org) that is meant for posting and reviewing changes. If you wouldn't mind posting your changes there in the future that makes it easier to comment and track patches. See http://www.m5sim.org/Commit_Access for more information about how to post a patch. Thanks, Ali _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
