----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1106/#review2322 -----------------------------------------------------------
Ship it! Other than my minor comment, this looks good to me. src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc <http://reviews.gem5.org/r/1106/#comment2743> Minor comment: this seems like a needless change and is in constrast with the coding style used in this file. - Brad Beckmann On March 19, 2012, 12:28 p.m., Tushar Krishna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1106/ > ----------------------------------------------------------- > > (Updated March 19, 2012, 12:28 p.m.) > > > Review request for Default, Nilay Vaish and Brad Beckmann. > > > Description > ------- > > Garnet: Stats at vnet granularity + code cleanup > > This patch > (1) Moves redundant code from fixed and flexible networks to > BaseGarnetNetwork. > (2) Prints network stats at vnet granularity. > > > Diffs > ----- > > src/mem/ruby/network/garnet/BaseGarnetNetwork.hh 75b524b64c28 > src/mem/ruby/network/garnet/BaseGarnetNetwork.cc 75b524b64c28 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh 75b524b64c28 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 75b524b64c28 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > 75b524b64c28 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh 75b524b64c28 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 75b524b64c28 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc > 75b524b64c28 > > Diff: http://reviews.gem5.org/r/1106/diff/ > > > Testing > ------- > > > Thanks, > > Tushar Krishna > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
