----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1095/#review2326 -----------------------------------------------------------
configs/ruby/Ruby.py <http://reviews.gem5.org/r/1095/#comment2755> 80 characters? configs/ruby/Ruby.py <http://reviews.gem5.org/r/1095/#comment2756> Odd way of stating what you want. src/mem/ruby/buffers/MessageBuffer.hh <http://reviews.gem5.org/r/1095/#comment2757> const? src/mem/ruby/buffers/MessageBuffer.hh <http://reviews.gem5.org/r/1095/#comment2758> Prefix with set? src/mem/ruby/network/Topology.cc <http://reviews.gem5.org/r/1095/#comment2759> It would be great if the comment explained a bit better what it is really doing. src/mem/ruby/network/topaz/TopazNetwork.hh <http://reviews.gem5.org/r/1095/#comment2763> Move up src/mem/ruby/network/topaz/TopazNetwork.hh <http://reviews.gem5.org/r/1095/#comment2764> const on all getters src/mem/ruby/network/topaz/TopazNetwork.hh <http://reviews.gem5.org/r/1095/#comment2765> Why returning a const unsigned? src/mem/ruby/network/topaz/TopazNetwork.hh <http://reviews.gem5.org/r/1095/#comment2766> const on all is/get methods src/mem/ruby/network/topaz/TopazNetwork.py <http://reviews.gem5.org/r/1095/#comment2760> Whitespace src/mem/ruby/network/topaz/TopazNetwork.py <http://reviews.gem5.org/r/1095/#comment2761> Whitespace src/mem/ruby/network/topaz/TopazNetwork.py <http://reviews.gem5.org/r/1095/#comment2762> Whitespace, and 80 char? - Andreas Hansson On March 20, 2012, 3:43 a.m., Valentin Puente wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1095/ > ----------------------------------------------------------- > > (Updated March 20, 2012, 3:43 a.m.) > > > Review request for Default, Nilay Vaish and Brad Beckmann. > > > Description > ------- > > Interface to integrate TOPAZ network simulator > (http://code.google.com/p/tpzsimul/) within GEM5-RUBY. Does not replace > ruby's interconnection network simulators (garnet and simple-network). It > just adds the hookups required to connect ruby and TOPAZ. You have to > download as "ext" TOPAZ from an external repo. > > To have a better perspective of the changes, you can follow the guide > provided in http://code.google.com/p/tpzsimul/wiki/GEM5Integration. In order > to integrate the compilation process of both simulators we have to slightly > modify main SConstruct and ruby SCons files. All the remaining changes are > constrained to Ruby. Main modifications have been done in > "src/mem/ruby/network/simple/PerfectSwitch.cc" > > > Diffs > ----- > > SConstruct be4990a2c764 > build_opts/ALPHA_Network_Topaz_test PRE-CREATION > build_opts/ALPHA_directory_topaz PRE-CREATION > build_opts/ALPHA_token_topaz PRE-CREATION > configs/ruby/Ruby.py be4990a2c764 > src/mem/ruby/buffers/MessageBuffer.hh be4990a2c764 > src/mem/ruby/buffers/MessageBuffer.cc be4990a2c764 > src/mem/ruby/network/Network.hh be4990a2c764 > src/mem/ruby/network/Topology.cc be4990a2c764 > src/mem/ruby/network/topaz/SConscript PRE-CREATION > src/mem/ruby/network/topaz/SConsopts PRE-CREATION > src/mem/ruby/network/topaz/TopazNetwork.hh PRE-CREATION > src/mem/ruby/network/topaz/TopazNetwork.cc PRE-CREATION > src/mem/ruby/network/topaz/TopazNetwork.py PRE-CREATION > src/mem/ruby/network/topaz/TopazSwitch.hh PRE-CREATION > src/mem/ruby/network/topaz/TopazSwitch.cc PRE-CREATION > src/mem/ruby/network/topaz/TopazSwitchFlow.hh PRE-CREATION > src/mem/ruby/network/topaz/TopazSwitchFlow.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/1095/diff/ > > > Testing > ------- > > Regression test seems to be working for the ruby protocols provided > > > Thanks, > > Valentin Puente > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
