> On March 21, 2012, 9:50 p.m., Steve Reinhardt wrote: > > src/mem/bus.cc, line 275 > > <http://reviews.gem5.org/r/1072/diff/2/?file=23998#file23998line275> > > > > Since this line is the same in both the if and else clauses, can we > > factor it out and put it at the end?
OK, I see in the next patch that this isn't going to hold true for long... never mind. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1072/#review2352 ----------------------------------------------------------- On March 9, 2012, 7:18 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1072/ > ----------------------------------------------------------- > > (Updated March 9, 2012, 7:18 a.m.) > > > Review request for Default. > > > Description > ------- > > MEM: Unify bus access methods and prepare for master/slave split > > This patch unifies the recvFunctional, recvAtomic and recvTiming to > all be based on a similar structure: 1) extract information about the > incoming packet, 2) send it out to the appropriate snoopers, 3) > determine where it is going, and 4) forward it to the right > destination. The naming of variables across the different access > functions is now consistent as well. > > Additionally, the patch introduces the member functions releaseBus and > retryWaiting to better distinguish between the two cases when we > should tell a sender to retry. The first case is when the bus goes > from busy to idle, and the second case is when it receives a retry > from a destination that did not immediatelly accept a packet. > > As a very minor change, the MMU debug flag is no longer used in the bus. > > > Diffs > ----- > > src/mem/bus.hh b4249e884de4 > src/mem/bus.cc b4249e884de4 > > Diff: http://reviews.gem5.org/r/1072/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
