> On April 2, 2012, 2:06 p.m., Ali Saidi wrote:
> > it's fine with the caveat that things which are deprecated today are 
> > normally gone tomorrow. Putting the no-deprecated warning is a bit 
> > dangerous. Is there perhaps a hash_map replacement that we could grab with 
> > version ifdefs?
> >
> 
> Andreas Hansson wrote:
>     The new data structure that replaces ext/hash_map is unordered_map. 
> However, ifdefs won't do the trick, as it seems we also have to add 
> -std=c++0x on the command line for this to work, but I'll do some more 
> digging around.
>

Seems like we should have a conf.CheckHeader for the unordered map and do the 
proper #ifdefs off that in base/hashmap.hh


- Nathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1119/#review2400
-----------------------------------------------------------


On April 2, 2012, 12:43 p.m., Andreas Hansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1119/
> -----------------------------------------------------------
> 
> (Updated April 2, 2012, 12:43 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Description
> -------
> 
> clang: Fix compilation problems with clang 3.0 on Ubuntu 12.04
> 
> This patch disables the warning for deprecated headers since the
> ext/hash_map is considered deprecated with clang 3.0 on Ubuntu 12.04
> (compiled against gcc 4.6 headers). It also fixes the build flags for
> the debug target that used to be shared with gcc.
> 
> 
> Diffs
> -----
> 
>   SConstruct 97f06a79b6f5 
>   src/SConscript 97f06a79b6f5 
> 
> Diff: http://reviews.gem5.org/r/1119/diff/
> 
> 
> Testing
> -------
> 
> util/regress all passing (disregarding t1000 and eio) with gcc 4.6.2, 
> and compiling with clang 2.9 and 3.0 on Ubuntu 12.04 and MacOSX 10.7.3
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to