> On April 6, 2012, 12:40 p.m., Gabe Black wrote: > > I'm all for code that makes reading the regression output easier. > > > > Other possible ideas: > > 1. Supress non-pass/fail information so the relevant lines don't scroll > > right off the screen, forcing a rerun to get a summary (may already be > > possible?) > > 2. Sort passes and fails so fails are last and grouped together. > > 3. It's nice to see things pass/fail as they finish, so maybe let them > > finish normally while collecting results. Then sort them into passes and > > fails, and print a summary with passes in one group, fails in another, and > > maybe even a count of each. Then you can see if your super fast test failed > > right away without waiting for the slow one, and after all the regressions > > run all night, you don't have to run them again to actually see what > > happened. And failures won't be lost in the crowd. > > 4. Send the summary/sorted list in the emails. We've had failures we didn't > > see for a while because they were surrounded by a bunch of passes. > > Andreas Hansson wrote: > I like the ideas :). That said, do you not think all of the above would > be separate patches?
Yes, that was what I assumed. These other things shouldn't be in this patch, but if you want to go farther along this direction they would be interesting things to look at. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1137/#review2486 ----------------------------------------------------------- On April 7, 2012, 4:35 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1137/ > ----------------------------------------------------------- > > (Updated April 7, 2012, 4:35 a.m.) > > > Review request for Default. > > > Description > ------- > > Regression: Add ANSI colours to highlight test status > > This patch adds a very basic pretty-printing of the test status > (passed or failed) to highlight failing tests even more: green for > passed, and red for failed. The printing only uses ANSI it the target > output is a tty and supports ANSI colours. Hence, any regression > scripts that are outputting to files or sending e-mails etc should > still be fine. > > > Diffs > ----- > > SConstruct a47fd7c2d44e > src/python/m5/util/terminal.py a47fd7c2d44e > tests/SConscript a47fd7c2d44e > > Diff: http://reviews.gem5.org/r/1137/diff/ > > > Testing > ------- > > Ran util/regress in a terminal and also through regression > script > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
