Hi Andreas,
We are trying to change the common use where users have to rename their
disks to "x86root" or ISA specific hard coded names. Also, users have to
hardcode the memory sizes in Benchmarks.py files. The options in this
patch is providing flexibility to the common case. There is no easy way
(that I know of) for adding multiple disks and distributed memory in FS
mode of gem5. For doing that people have to write their own FS scripts
anyway. This is just an enhancement over what is currently available in
the FS scripts (one disk + one memory).
Jayneel
On 04/17/2012 09:56 AM, Andreas Hansson wrote:
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1150/
configs/common/Options.py
<http://reviews.gem5.org/r/1150/diff/1/?file=26065#file26065line176>
(Diff revision 1)
def addFSOptions(parser):
176
parser.add_option("--disk-image", action="store", type="string",
default=None,
What if there are multiple disks?
configs/common/Options.py
<http://reviews.gem5.org/r/1150/diff/1/?file=26065#file26065line180>
(Diff revision 1)
def addFSOptions(parser):
180
parser.add_option("--mem-size", action="store", type="string",
default=None
What if there are multiple memories? What about memories of different
characteristics?
(the comment also says disk image...)
configs/example/fs.py
<http://reviews.gem5.org/r/1150/diff/1/?file=26066#file26066line89>
(Diff revision 1)
89
bm = [SysConfig(), SysConfig()]
89
bm = [SysConfig(disk=options.disk_image, mem=options.mem_size),
SysConfig(disk=options.disk_image, mem=options.mem_size)]
Oversimplification when using distributed memories of different size/type.
configs/example/fs.py
<http://reviews.gem5.org/r/1150/diff/1/?file=26066#file26066line91>
(Diff revision 1)
91
bm = [SysConfig()]
91
bm = [SysConfig(disk=options.disk_image, mem=options.mem_size)]
Same as before.
configs/example/ruby_fs.py
<http://reviews.gem5.org/r/1150/diff/1/?file=26067#file26067line74>
(Diff revision 1)
74
bm = [SysConfig()]
74
bm = [SysConfig(disk=options.disk_image, mem=options.mem_size)]
Same as before.
- Andreas
On April 16th, 2012, 11:53 a.m., Jayneel Gandhi wrote:
Review request for Default.
By Jayneel Gandhi.
/Updated April 16, 2012, 11:53 a.m./
Description
Added the options to Options.py for FS mode with backward compatibility. It is
good to provide an option to specify the disk image and the memory size from
command line since a lot of disk images are created to support different
benchmark suites as well as per user needs. Change in program also leads to
change in memory requirements. These options provide the interface to provide
both disk image and memory size from the command line and gives more
flexibility.
Testing
Testing done to confirm backward compatibility
Diffs
* configs/common/Options.py (a6830d615effc2e644fd3ebd2553c569c1d4607f)
* configs/example/fs.py (a6830d615effc2e644fd3ebd2553c569c1d4607f)
* configs/example/ruby_fs.py
(a6830d615effc2e644fd3ebd2553c569c1d4607f)
View Diff <http://reviews.gem5.org/r/1150/diff/>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
