> On April 22, 2012, 4:57 p.m., Steve Reinhardt wrote: > > Looking good, definitely pretty close. Thanks for the tweaks. The commit > > message also needs to be updated a bit too.
Oops! I'll fix that. > On April 22, 2012, 4:57 p.m., Steve Reinhardt wrote: > > src/arch/x86/tlb.cc, line 107 > > <http://reviews.gem5.org/r/1155/diff/3/?file=26115#file26115line107> > > > > Does it make sense to move this up before the freeList.empty() check so > > we don't unnecessarily evict a block if this check turns out to be true? Sure. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1155/#review2589 ----------------------------------------------------------- On April 22, 2012, 5:31 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1155/ > ----------------------------------------------------------- > > (Updated April 22, 2012, 5:31 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8960:78597062cf81 > --------------------------- > X86: Clear out duplicate TLB entries when adding a new one. > > It's possible for two page table walks to overlap which will go in the same > place in the TLB's trie. They would land on top of each other, so this change > adds some code which clears out any potentially conflicting entries before > adding a new one. > > > Diffs > ----- > > src/arch/x86/tlb.cc 24b06cbf2d67 > > Diff: http://reviews.gem5.org/r/1155/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
