----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1164/#review2596 -----------------------------------------------------------
Ship it! I assume the deleted includes are ones that would need to be changed, but then you noticed that they weren't actually used. You might want to mention that in the commit message. - Steve Reinhardt On April 22, 2012, 11:28 p.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1164/ > ----------------------------------------------------------- > > (Updated April 22, 2012, 11:28 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8960:7a8f6ddfbedf > --------------------------- > ISA: Put parser generated files in a "generated" directory. > > This is to avoid collision with non-generated files. > > > Diffs > ----- > > src/arch/SConscript 24b06cbf2d67 > src/arch/alpha/registers.hh 24b06cbf2d67 > src/arch/arm/insts/macromem.cc 24b06cbf2d67 > src/arch/arm/registers.hh 24b06cbf2d67 > src/arch/mips/registers.hh 24b06cbf2d67 > src/arch/power/registers.hh 24b06cbf2d67 > src/arch/sparc/registers.hh 24b06cbf2d67 > src/arch/x86/faults.cc 24b06cbf2d67 > src/arch/x86/insts/badmicroop.cc 24b06cbf2d67 > src/arch/x86/registers.hh 24b06cbf2d67 > > Diff: http://reviews.gem5.org/r/1164/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
