> On April 3, 2011, 5:44 p.m., Gabe Black wrote: > > src/arch/x86/linux/linux.hh, line 112 > > <http://reviews.gem5.org/r/591/diff/1/?file=11015#file11015line112> > > > > These RUSAGE and RLIMIT constants come from generic header files in > > Linux, not one specific to X86. If they aren't there already, they should > > be in a base class, not an x86 (or especially a 64 bit x86) subclass.
I've address this in a newly submitted patch (since I can't update this one). > On April 3, 2011, 5:44 p.m., Gabe Black wrote: > > src/arch/x86/linux/linux.hh, line 127 > > <http://reviews.gem5.org/r/591/diff/1/?file=11015#file11015line127> > > > > This constant is wrong according to > > http://lxr.linux.no/linux+*/include/asm-generic/resource.h#L26. This should > > be NPROC. Similarly 7 is NOFILE, 8 is MEMLOCK, and 9 is AS (VMEM doesn't > > seem to exist). There are some others which have been left out. I've address this in a newly submitted patch (since I can't update this one). > On April 3, 2011, 5:44 p.m., Gabe Black wrote: > > src/arch/x86/linux/linux.hh, line 212 > > <http://reviews.gem5.org/r/591/diff/1/?file=11015#file11015line212> > > > > The indentation here is off. I've address this in a newly submitted patch (since I can't update this one). > On April 3, 2011, 5:44 p.m., Gabe Black wrote: > > src/arch/x86/linux/linux.hh, line 236 > > <http://reviews.gem5.org/r/591/diff/1/?file=11015#file11015line236> > > > > These constants also need to be fixed, or removed if the 64 bit > > versions get promoted to a base class. I've address this in a newly submitted patch (since I can't update this one). - Marc ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/591/#review1097 ----------------------------------------------------------- On March 17, 2011, 4:06 p.m., Lisa Hsu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/591/ > ----------------------------------------------------------- > > (Updated March 17, 2011, 4:06 p.m.) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Description > ------- > > X86: rlimit: Another patch from Vince Weaver > > > Diffs > ----- > > src/arch/x86/linux/linux.hh 2e269d6fb3e6 > src/arch/x86/linux/syscalls.cc 2e269d6fb3e6 > > Diff: http://reviews.gem5.org/r/591/diff/ > > > Testing > ------- > > > Thanks, > > Lisa Hsu > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
