I’d suggest to use mercurial queues to create the patch. I.e. make sure your repo is up to date, then make your changes and create a patch with qnew/qrefresh.
Andreas From: Hamid Reza Khaleghzadeh [mailto:[email protected]] On Behalf Of Hamid Reza Khaleghzadeh Sent: 17 May 2012 09:34 To: Hamid Reza Khaleghzadeh; Default; Andreas Hansson Subject: Re: Review Request: Resetting/dumping ruby_stats when gem5 stats is reset/dumped This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1202/ Review request for Default. By Hamid Reza Khaleghzadeh. Updated May 17, 2012, 1:33 a.m. Changes I have created diff file again. But I think the problem still exists (I found this from View Diff). Perhaps the way which diff file created is wrong. In my approach, main GEM5 source code exists in folder "a" and modified one is in folder "b". I create diff file as following: "diff -ru a/ b/ > modify.patch" Could you tell me what is wrong? By the way, the patch is applied to folder "a". I found that patch is correct. Thanks Description Hello Mr./Mrs. reviewer, This patch modifies GEM5 source code so that ruby stats is reset/dumped when gem5 stats is being reset/dumped. Hope this is useful Diffs (updated) * b/src/base/output.cc (a/src/base/output.cc) * b/src/base/statistics.hh (a/src/base/statistics.hh) * b/src/base/statistics.cc (a/src/base/statistics.cc) * b/src/base/stats/text.cc (a/src/base/stats/text.cc) * b/src/mem/ruby/profiler/Profiler.cc (a/src/mem/ruby/profiler/Profiler.cc) * b/src/mem/ruby/system/System.hh (a/src/mem/ruby/system/System.hh) * b/src/mem/ruby/system/System.cc (a/src/mem/ruby/system/System.cc) View Diff<http://reviews.gem5.org/r/1202/diff/> -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
