-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1201/#review2711
-----------------------------------------------------------


Marc, can you only post the files that you have either modified or created on 
your own?
It is not necessary to post all the stats, config files that get updated with 
this
change.

- Nilay Vaish


On May 16, 2012, 8:37 p.m., Marc Orr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1201/
> -----------------------------------------------------------
> 
> (Updated May 16, 2012, 8:37 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Description
> -------
> 
> Adding regression tests for m5threads to text x86 and the new futex system 
> call. Note, m5threads seems to be broken with Ruby in the SPARC ISA and with 
> the classic caches in x86. The ruby test was already being skipped with SPARC 
> ISA. The patch also skips testing m5threads with the classic caches + x86 
> combination. When these problems are addressed, the skip files should be 
> removed.
> 
> Changeset 8986:13241f5fae1b
> ---------------------------
> regression tester: add tests to exercise m5threads with the x86 ISA.
> 
> These regressions also exercies the futex system call in syscall emulation 
> mode.
> 
> 
> Diffs
> -----
> 
>   
> tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/o3-timing-mp/config.ini 
> PRE-CREATION 
>   tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/o3-timing-mp/simerr 
> PRE-CREATION 
>   tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/o3-timing-mp/simout 
> PRE-CREATION 
>   tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/o3-timing-mp/skip 
> 4388495beb44ba859d20177371caf9e14902ef91 
>   
> tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/o3-timing-mp/stats.txt 
> PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/simple-atomic-mp/config.ini
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/simple-atomic-mp/simerr 
> PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/simple-atomic-mp/simout 
> PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/simple-atomic-mp/stats.txt
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/simple-timing-mp-ruby/config.ini
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/simple-timing-mp-ruby/ruby.stats
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/simple-timing-mp-ruby/simerr
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/simple-timing-mp-ruby/simout
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/simple-timing-mp-ruby/stats.txt
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/simple-timing-mp/config.ini
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/simple-timing-mp/simerr 
> PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/simple-timing-mp/simout 
> PRE-CREATION 
>   tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/simple-timing-mp/skip 
> 4388495beb44ba859d20177371caf9e14902ef91 
>   
> tests/quick/se/40.m5threads-test-atomic/ref/x86/linux/simple-timing-mp/stats.txt
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/o3-timing-mp/config.ini
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/o3-timing-mp/simerr 
> PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/o3-timing-mp/simout 
> PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/o3-timing-mp/stats.txt
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/simple-atomic-mp/config.ini
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/simple-atomic-mp/simerr
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/simple-atomic-mp/simout
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/simple-atomic-mp/stats.txt
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/simple-timing-mp-ruby/config.ini
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/simple-timing-mp-ruby/ruby.stats
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/simple-timing-mp-ruby/simerr
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/simple-timing-mp-ruby/simout
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/simple-timing-mp-ruby/skip
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/simple-timing-mp-ruby/stats.txt
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/simple-timing-mp/config.ini
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/simple-timing-mp/simerr
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/simple-timing-mp/simout
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/sparc/linux/simple-timing-mp/stats.txt
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/o3-timing-mp/config.ini
>  PRE-CREATION 
>   tests/quick/se/40.m5threads-test___thread/ref/x86/linux/o3-timing-mp/simerr 
> PRE-CREATION 
>   tests/quick/se/40.m5threads-test___thread/ref/x86/linux/o3-timing-mp/simout 
> PRE-CREATION 
>   tests/quick/se/40.m5threads-test___thread/ref/x86/linux/o3-timing-mp/skip 
> 4388495beb44ba859d20177371caf9e14902ef91 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/o3-timing-mp/stats.txt
>  4388495beb44ba859d20177371caf9e14902ef91 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/simple-atomic-mp/config.ini
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/simple-atomic-mp/simerr
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/simple-atomic-mp/simout
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/simple-atomic-mp/stats.txt
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/simple-timing-mp-ruby/config.ini
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/simple-timing-mp-ruby/ruby.stats
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/simple-timing-mp-ruby/simerr
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/simple-timing-mp-ruby/simout
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/simple-timing-mp-ruby/stats.txt
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/simple-timing-mp/config.ini
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/simple-timing-mp/simerr
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/simple-timing-mp/simout
>  PRE-CREATION 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/simple-timing-mp/skip 
> 4388495beb44ba859d20177371caf9e14902ef91 
>   
> tests/quick/se/40.m5threads-test___thread/ref/x86/linux/simple-timing-mp/stats.txt
>  4388495beb44ba859d20177371caf9e14902ef91 
>   tests/quick/se/40.m5threads-test___thread/test.py PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/1201/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marc Orr
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to