> On May 18, 2012, 6:33 a.m., Nilay Vaish wrote: > > This is slightly unrelated. Why does a page table walker needs a dma port?
I suspect it is just a convenient way of issuing a queued read/write without having to deal with the flow control. The patch only shift the functionality...did not consider changing the design :) - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1203/#review2713 ----------------------------------------------------------- On May 17, 2012, 5:10 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1203/ > ----------------------------------------------------------- > > (Updated May 17, 2012, 5:10 a.m.) > > > Review request for Default. > > > Description > ------- > > MEM: Add a snooping DMA port subclass for table walker > > This patch makes the (device) DmaPort non-snooping and removes the > recvSnoop constructor parameter and instead introduces a > SnoopingDmaPort subclass for the ARM table walker. > > Functionality is unchanged, as are the stats, and the patch merely > clarifies that the normal DMA ports are not snooping (although they > may issue requests that are snooped by others, as done with PCI, PCIe, > AMBA4 ACE etc). > > Currently this port is declared in the ARM table walker as it is not > used anywhere else. If other ports were to have similar behaviour it > could be moved in a future patch. > > > Diffs > ----- > > src/arch/arm/table_walker.hh 7100059f7bfd > src/arch/arm/table_walker.cc 7100059f7bfd > src/dev/io_device.hh 7100059f7bfd > src/dev/io_device.cc 7100059f7bfd > > Diff: http://reviews.gem5.org/r/1203/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
