----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1168/#review2718 -----------------------------------------------------------
Would it make more sense for this to be a warning rather than a panic? I forget what the original symptom was we were trying to address, but I think it was something like gem5 crashing or hanging somewhat mysteriously. A warning should be as good as a panic message in eliminating the mystery, and the nice thing about a warning is that we don't have to worry as much about picking the right size. - Steve Reinhardt On April 29, 2012, 2:50 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1168/ > ----------------------------------------------------------- > > (Updated April 29, 2012, 2:50 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8974:bc9705db542b > --------------------------- > Syscalls: panic when the length argument to mmap is excessive. > > If the length argument to mmap is larger than the arbitrary but reasonable > limit of 4GB, there's a good chance that the value is nonsense and not > intentional. Rather than attempting to satisfy the mmap anyway, this change > makes gem5 panic to make it more apparent what's going wrong. > > > Diffs > ----- > > src/sim/syscall_emul.hh d69afa89c2ee > > Diff: http://reviews.gem5.org/r/1168/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
