> On May 18, 2012, 6:31 a.m., Nilay Vaish wrote: > > Have you tested this? It seems this is not correct. Try to mimic ruby_fs.py. > > Marc Orr wrote: > Hrmmm... It seemed to work ok. Let me be specific about the test I did: > 1. SPARC atomics 2 CPUs: pass > 2. SPARC threads 2 CPUs: pass > 3. SPARC atomics 4 CPUs: HANGS > 4. SPARC threads 4 CPUs: HANGS > 3. X86 atomics 4 CPUs: pass > 4. X86 threads 4 CPUS: pass > > I sort of tried to follow o3-timing-mp-ruby.py test configuration, except > that I let the ruby_create_system function call hook up the memory and system > ports. > > Initially I did try to use the ruby portion of se.py as a guide (it looks > similar to ruby_fs.py I think), but the sparc interrupt controller doesn't > have master/slave ports, so bad things happened. > > Can you be more specific about your concerns with this implementation?
Some how I posted the wrong comment. Specifically, the testing I intended to post is: 1. SPARC simple_atomics: HANGS 2. SPARC simple___threads: pass 3. X86 simple_atomics: pass 4. X86 simple___threads: pass - Marc ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1199/#review2712 ----------------------------------------------------------- On May 16, 2012, 6:19 p.m., Marc Orr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1199/ > ----------------------------------------------------------- > > (Updated May 16, 2012, 6:19 p.m.) > > > Review request for Default. > > > Description > ------- > > The simple-timing-mp-ruby.py configuration file did not get updated to work > with some recent updates. It is used in the m5threads regression. Currently > the m5threads regression actually skips this test. I left the skip file in > there because m5threads does not seem to work with ruby for the sparc ISA > with > 2 CPUs. That said, it does work with x86, which I plan to add a > regression for. > > Changeset 8985:94ac17de30e1 > --------------------------- > regression tester: Fix some bugs in simple-timing-mp-ruby.py. > > > Diffs > ----- > > tests/configs/simple-timing-mp-ruby.py > 4388495beb44ba859d20177371caf9e14902ef91 > > Diff: http://reviews.gem5.org/r/1199/diff/ > > > Testing > ------- > > > Thanks, > > Marc Orr > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
