----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1196/#review2742 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On May 16, 2012, 7:45 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1196/ > ----------------------------------------------------------- > > (Updated May 16, 2012, 7:45 a.m.) > > > Review request for Default. > > > Description > ------- > > Config: Use the attribute naming and include ports in JSON > > This patch changes the organisation of the JSON output slightly to > make it easier to traverse and use the files. Most importantly, the > hierarchical dictionaries now use keys that correspond to the > attribute names also in the case of VectorParams (used to be > e.f. "cpu0 cpu1"). It also adds the name and the path to each > SimObject directory entry. Before this patch, to get cpu0, you would > have to query dict['system']['cpu0 cpu1'][0] and this could be a dict > with 'cpu0' : { cpu parameters }. Now you use dict['system']['cpu'][0] > and get { cpu parameters } (where one is "name" : "cpu0"). > > Additionally this patch includes more verbose information about the > ports, specifying their role, and using a list rather than a > concatenated string for the peer. Hopefully this is still valid > JSON. At least Python 2.7 seems to be happy. > > > Diffs > ----- > > src/python/m5/SimObject.py f681719e2e99 > src/python/m5/params.py f681719e2e99 > > Diff: http://reviews.gem5.org/r/1196/diff/ > > > Testing > ------- > > Ran for all the systems in the regressions and applied a bunch > of Python scripts to poke around in the output > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
