----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1194/#review2756 -----------------------------------------------------------
Ship it! As I said in the other review, seems like it would have been easier to skip the arch/generic part, but otherwise this looks fine. - Steve Reinhardt On May 15, 2012, 5:56 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1194/ > ----------------------------------------------------------- > > (Updated May 15, 2012, 5:56 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9008:cf31213798ec > --------------------------- > ISA: Make the decode function part of the ISA's decoder. > > > Diffs > ----- > > src/arch/alpha/SConscript f681719e2e99 > src/arch/alpha/decoder.hh PRE-CREATION > src/arch/alpha/decoder.cc PRE-CREATION > src/arch/alpha/isa/main.isa f681719e2e99 > src/arch/arm/SConscript f681719e2e99 > src/arch/arm/decoder.hh PRE-CREATION > src/arch/arm/decoder.cc PRE-CREATION > src/arch/arm/isa/includes.isa f681719e2e99 > src/arch/generic/SConscript PRE-CREATION > src/arch/generic/decoder.hh PRE-CREATION > src/arch/generic/decoder.cc PRE-CREATION > src/arch/isa_parser.py f681719e2e99 > src/arch/mips/SConscript f681719e2e99 > src/arch/mips/decoder.hh PRE-CREATION > src/arch/mips/decoder.cc PRE-CREATION > src/arch/mips/isa/includes.isa f681719e2e99 > src/arch/power/SConscript f681719e2e99 > src/arch/power/decoder.hh PRE-CREATION > src/arch/power/decoder.cc PRE-CREATION > src/arch/power/isa/includes.isa f681719e2e99 > src/arch/sparc/SConscript f681719e2e99 > src/arch/sparc/decoder.hh PRE-CREATION > src/arch/sparc/decoder.cc PRE-CREATION > src/arch/sparc/isa/includes.isa f681719e2e99 > src/arch/x86/SConscript f681719e2e99 > src/arch/x86/decoder.hh PRE-CREATION > src/arch/x86/decoder.cc PRE-CREATION > src/arch/x86/isa/includes.isa f681719e2e99 > src/arch/x86/isa_traits.hh f681719e2e99 > src/cpu/SConscript f681719e2e99 > src/cpu/decode_cache.hh f681719e2e99 > src/cpu/decode_cache.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/1194/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
