> On May 20, 2012, 7:58 a.m., Ali Saidi wrote: > > src/dev/Device.py, line 45 > > <http://reviews.gem5.org/r/1204/diff/1/?file=26537#file26537line45> > > > > This doesn't seem like it adds any value
I am a bit unsure what "this" refers to. The DmaDevice is moved to DmaDevice.py - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1204/#review2738 ----------------------------------------------------------- On May 18, 2012, 5:09 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1204/ > ----------------------------------------------------------- > > (Updated May 18, 2012, 5:09 a.m.) > > > Review request for Default. > > > Description > ------- > > DMA: Split the DMA device and IO device into seperate files > > This patch moves the DMA device to its own set of files, splitting it > from the IO device. There are no behavioural changes associated with > this patch. > > The patch also grabs the opportunity to do some very minor tidying up, > including some white space removal and pruning some redundant > parameters. > > Besides the immediate benefits of the separation-of-concerns, this > patch also makes upcoming changes more streamlined as it split the > devices that are only slaves and the DMA device that also acts as a > master. > > > Diffs > ----- > > src/dev/DmaDevice.py PRE-CREATION > src/dev/Device.py 7100059f7bfd > src/arch/arm/table_walker.hh 7100059f7bfd > src/dev/Pci.py 7100059f7bfd > src/dev/SConscript 7100059f7bfd > src/dev/arm/RealView.py 7100059f7bfd > src/dev/arm/amba_device.hh 7100059f7bfd > src/dev/dma_device.hh PRE-CREATION > src/dev/dma_device.cc PRE-CREATION > src/dev/io_device.hh 7100059f7bfd > src/dev/io_device.cc 7100059f7bfd > src/dev/pcidev.hh 7100059f7bfd > > Diff: http://reviews.gem5.org/r/1204/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
