----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1206/#review2787 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On May 18, 2012, 9:11 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1206/ > ----------------------------------------------------------- > > (Updated May 18, 2012, 9:11 a.m.) > > > Review request for Default. > > > Description > ------- > > Config: Exit with fatal if a port is already connected > > This patch turns the existing warning into a fatal, as there should > never be any cases where a (non-vector) port is assigned to and then > later connected to something else. If this behaviour is allowed, as it > used to be, there are cases where the wrong number of C++ ports are > created when instantiating objects with VectorPorts (obviously that > could be fixed, but the better approach is to simply not allow it). > > > Diffs > ----- > > src/python/m5/params.py 7100059f7bfd > > Diff: http://reviews.gem5.org/r/1206/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
